feat: add transformHead hook
#1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you can check it working in this repo: https://github.com/userquin/vite-pwa-vitepress-integration
|
|
I've made some changes, check once if they work well for you. |
brc-dd
force-pushed
the
feat/head-build-hook
branch
from
6b87c16
to
baa14de
Compare
brc-dd
force-pushed
the
feat/head-build-hook
branch
from
baa14de
to
ccafa4b
Compare
|
@brc-dd I will try to check it later |
userquin
commented
Sep 12, 2022
|
integration repo updated: the pwa-prompt also configured |
brc-dd
reviewed
Sep 12, 2022
|
I'll check if we can also integrate the head in the client build to solve the hydration missmatch, changes LGTM (I think it can be merged: in the meantime, we can add also the hydration problems to transformHead) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1322