Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add home-hero-image slot #1528

Merged
merged 5 commits into from Dec 28, 2022
Merged

Conversation

g4rry420
Copy link
Contributor

Signed-off-by: GurkiranSingh gurkiransinghk@gmail.com

Resolves #1062
I am not sure if slot drilling (I don't know even if it is a term) is good way to solve this. If there is any other way, please let me know as I am learning Vue on the go. Thanks :)

g4rry420 and others added 2 commits October 22, 2022 11:02
Signed-off-by: GurkiranSingh <gurkiransinghk@gmail.com>
@brc-dd brc-dd self-assigned this Nov 10, 2022
@brc-dd brc-dd changed the title feat: Added slot for Hero Image feat(theme): add home-hero-image slot Dec 28, 2022
@brc-dd brc-dd merged commit e72998b into vuejs:main Dec 28, 2022
@g4rry420 g4rry420 deleted the issue_1062 branch December 28, 2022 20:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hero image slot
2 participants