New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(a11y): add aria-hidden to line numbers wrapper #1675

Merged

brc-dd merged 1 commit into vuejs:main from chenxsan:feature/add-aria-hidden-for-line-numbers

Dec 9, 2022

Contributor

chenxsan commented Dec 7, 2022

It seems to be more reasonable to set aria-hidden to true for those line numbers.


          feat: add aria-hidden to line numbers wrapper

485f72a

brc-dd approved these changes

View reviewed changes

brc-dd changed the title ~~feat: add aria-hidden to line numbers wrapper~~ perf(a11y): add aria-hidden to line numbers wrapper

brc-dd merged commit 4c5a892 into vuejs:main

chenxsan deleted the feature/add-aria-hidden-for-line-numbers branch

December 9, 2022 12:12

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.