Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect aside sticky position #2114

Closed
3 tasks done
Hfutsora opened this issue Mar 21, 2023 · 3 comments · Fixed by #2115
Closed
3 tasks done

Incorrect aside sticky position #2114

Hfutsora opened this issue Mar 21, 2023 · 3 comments · Fixed by #2115
Labels
theme Related to the theme

Comments

@Hfutsora
Copy link

Describe the bug

When there is a top banner and no sidebar, the sticky position of the aside is incorrect.

Reproduction

image

You can find this bug on vue doc.

Expected behavior

The position of the aside should be correct.

System Info

System:
    OS: Windows 10 10.0.19044
    CPU: (16) x64 Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz
    Memory: 20.41 GB / 31.87 GB
  Binaries:
    Node: 16.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - C:\Program Files\nodejs\yarn.CMD
    npm: 8.11.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (111.0.1661.44)
    Internet Explorer: 11.0.19041.1566

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@Hfutsora Hfutsora added the bug: pending triage Maybe a bug, waiting for confirmation label Mar 21, 2023
@brc-dd
Copy link
Member

brc-dd commented Mar 21, 2023

Vue docs are using a different theme: https://github.com/vuejs/theme

@brc-dd brc-dd closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2023
@Hfutsora
Copy link
Author

I reproduced this issue in this repository using vitepress.

image

@brc-dd
Copy link
Member

brc-dd commented Mar 21, 2023

Ah, it's only when there is no sidebar present (footer is shown, it pushes the content up).

@brc-dd brc-dd added theme Related to the theme and removed bug: pending triage Maybe a bug, waiting for confirmation labels Mar 21, 2023
@brc-dd brc-dd linked a pull request Mar 21, 2023 that will close this issue
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants