Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme): add semantic markup to local search dialog #2325

Merged
merged 10 commits into from Jun 10, 2023
Merged

feat(theme): add semantic markup to local search dialog #2325

merged 10 commits into from Jun 10, 2023

Conversation

userquin
Copy link
Collaborator

@userquin userquin commented May 1, 2023 •
edited

This PR includes:

  • add semantic markup to dialog and result
  • prevent close search dialog when no search found: selectedIndex initialized with -1 and only updated to 0 when results found
  • focus search input on clear button click
  • disables clear button when no search
  • css style for disabled clear button

closes #2232

@userquin userquin marked this pull request as draft May 1, 2023 11:53
@userquin
Copy link
Collaborator Author

userquin commented May 1, 2023

I'll fix also here semantic markup... just a few changes required

@userquin userquin changed the title feat(theme): add reset local search button logic feat(theme): add semantic markup to local search dialog May 1, 2023
@userquin userquin marked this pull request as ready for review May 1, 2023 12:37
@brc-dd brc-dd self-requested a review May 8, 2023 20:07
@brc-dd brc-dd merged commit 4ddb96f into vuejs:main Jun 10, 2023
8 checks passed
@userquin userquin deleted the userquin/feat-reset-localsearch-button branch June 10, 2023 09:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brc-dd brc-dd brc-dd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local search: review html markup, should be semantic
2 participants
@userquin @brc-dd