Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): mobile and theme switcher #2354

Merged
merged 2 commits into from May 10, 2023
Merged

fix(theme): mobile and theme switcher #2354

merged 2 commits into from May 10, 2023

Conversation

userquin
Copy link
Collaborator

@userquin userquin commented May 9, 2023 •
edited

This PR includes (LightHouse complains):

  • NavBar content-body: add 0.5rem column gap in narrow/mobile screens (<=768px), search and hamburger buttons overlap
  • set 48px to search button
  • remove label wrapper in VPSwitchAppearance.vue

imagen

imagen

@brc-dd brc-dd merged commit d6c0985 into vuejs:main May 10, 2023
8 checks passed
@userquin userquin deleted the userquin/fix-mobile-and-theme-switcher-lh branch May 10, 2023 16:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@userquin @brc-dd