feat(theme): home features section layout consistent #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brc-dd
reviewed
May 18, 2023
|
@brc-dd And when the length is one, should it be set to
Otherwise it is like this:
I think it is more reasonable to set the style as |
|
Yeah for length = 1, |
|
Yeah, I have resubmitted the code.😀 |
brc-dd
approved these changes
May 19, 2023
|
Removed the grid-1 thing, because there is no CSS corresponding to that -- it is the default behavior. We just need to make sure to not apply grid-4 on that case. Updated the condition accordingly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2318