Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): cli shortcuts add restart command #2403

Merged
merged 4 commits into from May 27, 2023

Conversation

alexzhang1030
Copy link
Contributor

add restart shortcut, copied from vite

@alexzhang1030 alexzhang1030 changed the title feat(node): cli shortcuts add restart feat(node): cli shortcuts add restart command May 22, 2023
@brc-dd
Copy link
Member

brc-dd commented May 22, 2023

Ah, restart might not work like this. It'll restart the vite server, but won't actually rerun the vitepress part. You'll need to pass createDevServer to bindShortcuts and run await server.close(); await createDevServer() in action.

@alexzhang1030
Copy link
Contributor Author

Thanks for reminding me, is this correct now? /cc @brc-dd

@brc-dd brc-dd self-assigned this May 25, 2023
@brc-dd brc-dd marked this pull request as draft May 27, 2023 08:31
@brc-dd brc-dd marked this pull request as ready for review May 27, 2023 09:23
@brc-dd brc-dd merged commit 64b06db into vuejs:main May 27, 2023
8 checks passed
@alexzhang1030 alexzhang1030 deleted the feat/cli-shortcuts-restart branch May 27, 2023 10:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants