Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): use brand color in skip link in dark theme #2431

Merged
merged 1 commit into from May 27, 2023

Conversation

azat-io
Copy link
Contributor

@azat-io azat-io commented May 27, 2023

The "Skip to content" button in the light theme currently uses the var(--vp-c-brand) color and var(--vp-c-green) in the dark theme.

var(--vp-c-brand) equals var(--vp-c-green) by default.

I use default VitePress theme and I customize var(--vp-c-brand), but I don't want to set var(--vp-c-green) because that color is used in the Tip container.

The current implementation looks like a bug.

@brc-dd brc-dd merged commit 62d1110 into vuejs:main May 27, 2023
8 checks passed
@azat-io azat-io deleted the fix/skip-color branch May 27, 2023 12:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants