You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By importing this symbol, the built-in local search achieves "mocking pageData in another app instance" and render other page as components.
This is unfair for third party themes, as they do not have same ability to this tricky job and provide a similar built-in theme.
Describe the solution you'd like
Export this symbol or stop using it. The default theme should not access vitepress private apis to "provide magic". Everything should work outside vitepress in order not to embarrass 3rd party themes.
Is your feature request related to a problem? Please describe.
Yes, the default theme has a built-in local search, while it's importing
dataSymbol
, which is private and not accessable outside vitepress.vitepress/src/client/theme-default/components/VPLocalSearchBox.vue
Line 30 in 80e734d
By importing this symbol, the built-in local search achieves "mocking pageData in another app instance" and render other page as components.
This is unfair for third party themes, as they do not have same ability to this tricky job and provide a similar built-in theme.
Describe the solution you'd like
Export this symbol or stop using it. The default theme should not access vitepress private apis to "provide magic". Everything should work outside vitepress in order not to embarrass 3rd party themes.
Describe alternatives you've considered
No response
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: