Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export useSidebar #2496

Merged
merged 5 commits into from
Jun 21, 2023
Merged

feat: export useSidebar #2496

merged 5 commits into from
Jun 21, 2023

Conversation

zonemeen
Copy link
Collaborator

@zonemeen zonemeen commented Jun 12, 2023

closes #1176, one of my custom components needs to use hasSidebar.

There should be some other developers who need to use the features in useSidebar.

@brc-dd
Copy link
Member

brc-dd commented Jun 19, 2023

IMO this should be exported from vitepress/theme instead as it is specific to the (default) theme.

@brc-dd brc-dd force-pushed the feat/export-useSidebar branch 2 times, most recently from 15f5145 to bb7f053 Compare June 19, 2023 15:34
@brc-dd
Copy link
Member

brc-dd commented Jun 19, 2023

Take a look. If it's fine, then merge it 🙌

@zonemeen
Copy link
Collaborator Author

I think it's fine to merge 👀

@brc-dd brc-dd merged commit c4909e4 into vuejs:main Jun 21, 2023
8 checks passed
@zonemeen zonemeen deleted the feat/export-useSidebar branch June 21, 2023 02:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide useSidebar from vitepress
2 participants