Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert!: sync defineConfig types with vite #2529

Merged
merged 1 commit into from Jun 20, 2023
Merged

revert!: sync defineConfig types with vite #2529

merged 1 commit into from Jun 20, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Jun 20, 2023

closes #2524

It looks like these changes broke many other projects. Especially the projects using something like this for i18n:

export const sharedConfig = defineConfig({...})

Not removing UserConfigFn and UserConfigExport types for now as some plugins like vite-pwa have started using them.

@brc-dd brc-dd merged commit cd03db8 into main Jun 20, 2023
8 checks passed
@brc-dd brc-dd deleted the revert-b3ded34 branch June 20, 2023 07:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot edit the config after calling defineConfig anymore
1 participant