Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: default theme search button background blends in with icon on mobile #2735

Closed
4 tasks done
import-brain opened this issue Aug 5, 2023 · 6 comments
Closed
4 tasks done
Labels
need more info Further information is requested

Comments

@import-brain
Copy link

Describe the bug

The default docs theme search button background blends in with the search icon on mobile.

IMG_2579

Reproduction

Go to vitepress.dev or fakerjs.dev on a mobile site

Expected behavior

The icon itself to seem more prominent so that users can more easily tell it’s a search button on first glance- maybe no background at all?

System Info

Apple iPhone 11
Google Chrome

Additional context

No response

Validations

@import-brain import-brain added the bug: pending triage Maybe a bug, waiting for confirmation label Aug 5, 2023
@brc-dd
Copy link
Member

brc-dd commented Aug 5, 2023

Which Chrome and iOS version are you on (share screenshot of chrome://version)? I'm not able to reproduce this:

image

@brc-dd brc-dd added need more info Further information is requested and removed bug: pending triage Maybe a bug, waiting for confirmation labels Aug 5, 2023
@import-brain
Copy link
Author

I'm on the iOS 17 beta, that might be why the issue is happening on my phone

IMG_2581
IMG_2580

@brc-dd
Copy link
Member

brc-dd commented Aug 5, 2023

Ah, yeah. That might be the cause. Can you check internally with Faker team once if this is happening on stable iOS version for anyone?

@import-brain
Copy link
Author

Ah, yeah. That might be the cause. Can you check internally with Faker team once if this is happening on stable iOS version for anyone?

Sure, I'll ping them right now

@import-brain
Copy link
Author

Hi @brc-dd ,

I checked internally with Faker team and none of them were able to replicate it on Android, iOS stable, and using multiple different browsers.

I just tried again and I can't replicate it either now 👀

I'll keep testing to see if I can get it to pop up again.

@brc-dd brc-dd closed this as completed in 063b0e5 Aug 5, 2023
@brc-dd
Copy link
Member

brc-dd commented Aug 5, 2023

It might be a glitch actually. We already have this code to make it transparent:

I also overrode the css var in 063b0e5 just to be double sure. Feel free to reopen or ping me in faker/vue discord if it happens again.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need more info Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants