fix(theme): use--vp-c-tip-
CSS variable for badge/block colors with typetip
#3434
+18
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr;: The CSS variables
--vp-c-gray
,--vp-c-indigo
,--vp-c-green
,--vp-c-yellow
and--vp-c-red
should not be directly used for components. Instead only--vp-c-default
--vp-c-brand
--vp-c-tip
--vp-c-success
--vp-c-warning
and--vp-c-danger
should to allow custom themes to easily use custom colors.Some CSS variables for components (such as badge, custom block and code block) directly used the CSS variables of the color palette (such as
--vp-c-yellow
) instead of the generic variables (--vp-c-warning
etc.).This lead to the issue that a custom theme can not simply add its own colors for (success/green, danger/red, warning/yellow and tip/purple) because it would not have been applied to all components.
Note that this is not a breaking change since the changed variables in this PR all default to the same values as before but now a custom theme can easily add its own color palette, by e.g. defining it like: