fix: append base to links #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you change this to default to 804954c#diff-332834eb76757b8e31926e411cef34f7207564d0bf5fd00a185b41d97b3403bfR53 This change broke on of our scripts (compile-time only). |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #252
As mentioned at #252 (comment), relative links are still working. If you guys want to keep it that way only and map
/footoscheme://path/fooinstead ofscheme://path/base/foothen the current external URL testing needs to be changed as/foomay not point to valid internal link ifbaseis set (ref: #458). If this is merged, then #458 can be closed as won't fix, i.e.scheme://pathis required if linking to any external link (incl. links outside the base).