Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize image source #514

Merged
merged 2 commits into from Feb 22, 2022
Merged

fix: normalize image source #514

merged 2 commits into from Feb 22, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Jan 31, 2022 •
edited

fixes #450

@yyx990803 yyx990803 merged commit 9270477 into vuejs:main Feb 22, 2022
@brc-dd brc-dd deleted the patch-9 branch February 22, 2022 03:36
@meteorlxy meteorlxy mentioned this pull request Jun 15, 2022
Closed
@meteorlxy
Copy link
Member

meteorlxy commented Jun 15, 2022 •
edited

I'm afraid it's not an ideal fix. Two problems:

  • The raw html <img> tag is not handled, then the behaviors of <img src="foo"> and ![](foo) are inconsistent.
  • It makes the vite.resolve.alias fail to work, because the plugin will prepend ./ to the alias.

@meteorlxy
Copy link
Member

IMO, the original behavior is consistent with vite + vue DX, so we might not need this plugin.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assets resolution inconsistency in Dev and Build modes
3 participants
@brc-dd @meteorlxy @yyx990803