Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom edit links #698

Merged
merged 6 commits into from Jun 6, 2022
Merged

feat: allow custom edit links #698

merged 6 commits into from Jun 6, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Jun 2, 2022

fixes: #694

@brc-dd brc-dd changed the title fix: allow bitbucket, gitlab, gitee in edit links feat: allow bitbucket, gitlab, gitee in edit links Jun 2, 2022
@RainKolwa
Copy link
Contributor

Hi, thank you for this PR. I have a small suggestion:
For GitLab, can we use :repo/edit/:branch/:path(the same to GitHub) as edit link pattern?
This would be more compatible with self-hosted GitLab which is still using older version(e.g. v12).

@kecrily
Copy link
Contributor

kecrily commented Jun 4, 2022

For GitLab, can we use :repo/edit/:branch/:path(the same to GitHub) as edit link pattern?

In my PR for the same issue, you can customize the style of the edit links

export default {
  themeConfig: {
    editLink: {
      style: 'github',
      domain: 'gitlab.com',
      repo: 'vuejs/vitepress',
      branch: 'next',
      dir: 'docs',
      text: 'Edit this page on GitHub'
    },
  }
}

More infomation https://github.com/vuejs/vitepress/pull/697/files

@brc-dd brc-dd changed the title feat: allow bitbucket, gitlab, gitee in edit links feat: allow custom edit links Jun 6, 2022
@brc-dd brc-dd requested a review from kiaking June 6, 2022 06:31
@kiaking kiaking merged commit 535e176 into vuejs:main Jun 6, 2022
@brc-dd brc-dd deleted the fix/edit-link branch June 6, 2022 07:42
D3SOX added a commit to D3SOX/arch-guide that referenced this pull request Jun 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[next] support external for editlink
4 participants