fix: add italic fonts #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it really necessary to have italic font built in? Why not fallback to other fonts. |
|
@kecrily Falling back doesn't appear to be working here. We had |
|
When will this be merged??? |
kiaking
approved these changes
Jun 16, 2022
brc-dd
added a commit
that referenced
this pull request
Jun 17, 2022
* refactor: refine global layout system * chore: remove unknown console log from release script * release: v1.0.0-alpha.2 * docs: add Layer0 deployment notes Co-authored-by: meteorlxy <meteor.lxy@foxmail.com> * docs: add cloudflare pages deploy (#797) close #369 Co-authored-by: Kia King Ishii <kia.king.08@gmail.com> * refactor: improve site data parsing (#780) * fix: copy code in non-secure contexts (#792) Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com> * fix(theme): add italic fonts (#759) (#777) fix #759 * docs: image migration guide for vuepress (#799) * refactor(types): use built-in utility type `Awaited` (#801) instead of explicitly defining it. (introduced in TS 4.5) * feat(theme): support themeable images for logo and hero (#745) Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com> Co-authored-by: Kia King Ishii <kia.king.08@gmail.com> Co-authored-by: Rishi Raj Jain <rishi18304@iiitd.ac.in> Co-authored-by: meteorlxy <meteor.lxy@foxmail.com> Co-authored-by: Percy Ma <kecrily@gmail.com> Co-authored-by: Linmj <33464433+cfmj@users.noreply.github.com> Co-authored-by: JD Solanki <47495003+jd-solanki@users.noreply.github.com> Co-authored-by: CHOYSEN <choysen@qq.com> Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #759