Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Title' links to '/' rather than '/base', causing 404 on GitHub Pages #787

Closed
3 tasks done
SirLich opened this issue Jun 13, 2022 · 2 comments
Closed
3 tasks done
Labels
bug: pending triage Maybe a bug, waiting for confirmation

Comments

@SirLich
Copy link

SirLich commented Jun 13, 2022

Describe the bug

The 'title' link in the top of the NavBar linked to the '/' instead of 'base', causing a 404 when you click it on GithubPages.

For example, my website has a base of 'sapiens-modding-wiki' since in GithubPages the base must match the repository name: https://sirlich.github.io/sapiens-modding-wiki/

When you click the 'title', it brings me to https://sirlich.github.io instead of https://sirlich.github.io/sapiens-modding-wiki/, causing a 404 to appear.

Reproduction

  1. Visit a site such as https://sirlich.github.io/sapiens-modding-wiki/
  2. Click the 'Sapiens Modding Wiki' on the top of the navbar
  3. Observe a 404
  4. Reload the page to see that the https://sirlich.github.io is unrelated to current vitepress docs

Expected behavior

I expect that I am redirected to https://sirlich.github.io/sapiens-modding-wiki/ as this matches the base defined in my config.

System Info

*GitHub Pages*.

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@SirLich SirLich added the bug: pending triage Maybe a bug, waiting for confirmation label Jun 13, 2022
@kecrily
Copy link
Contributor

kecrily commented Jun 13, 2022

We have a base config, you can use it custom the dir your website used.

ref https://vitepress.vuejs.org/config/app-configs.html#base

@brc-dd
Copy link
Member

brc-dd commented Jun 13, 2022

Was fixed by #718. The fix will be there in next alpha release.

@brc-dd brc-dd closed this as completed Jun 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: pending triage Maybe a bug, waiting for confirmation
Projects
None yet
Development

No branches or pull requests

3 participants