Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): change sponsor link class name to bypass adblock #867

Merged
merged 3 commits into from Jun 26, 2022

Conversation

userquin
Copy link
Collaborator

closes #866

@brc-dd
Copy link
Member

brc-dd commented Jun 26, 2022

x-sponsor-link is also likely to be hidden by some ad blockers. Lets change it to something like sp-link.


We should also track Carbon Ads (separately), currently this is what I get on my browser (using uBlock Origin):

image

I was hoping we could have something similar to Nuxt here.

image

There was an effort for this #348, but that PR went stale. The fix seemed quite straightforward. If you wish (and have some time to implement), we can have that here itself or maybe a separate PR by anyone. Either works for me.

@userquin
Copy link
Collaborator Author

upps, so we should ommit the sponsor key, fixing it...

@brc-dd
Copy link
Member

brc-dd commented Jun 26, 2022

Yeah, this one is fine. Using vp-sponsor-foo should also not cause issues with most of the ad-blockers, but that will probably conflict with our sponsors components.

@brc-dd brc-dd changed the title fix: change sponsor link class name for ad block fix(theme): change sponsor link class name to bypass adblock Jun 26, 2022
@brc-dd brc-dd requested a review from kiaking June 26, 2022 16:32
@brc-dd brc-dd merged commit e33955e into vuejs:main Jun 26, 2022
@userquin userquin deleted the userquin/fix-sponsor-link-ad-block branch June 26, 2022 17:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sponsor-link hidden when ad block present
2 participants