Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting is not the selected element #956

Closed
3 tasks done
newives opened this issue Jul 9, 2022 · 1 comment · Fixed by #970
Closed
3 tasks done

Highlighting is not the selected element #956

newives opened this issue Jul 9, 2022 · 1 comment · Fixed by #970
Labels
enhancement New feature or request

Comments

@newives
Copy link

newives commented Jul 9, 2022

Describe the bug

Highlighting is not the selected element
图片

Reproduction

reproduce

Expected behavior

I want to highlight the selected element thank you

System Info

System:
    OS: macOS 12.4
    CPU: (8) x64 Intel(R)
    Memory: 3.12 GB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.14.0 - /usr/local/bin/node
    Yarn: 1.22.11 - /usr/local/bin/yarn
    npm: 8.3.1 - /usr/local/bin/npm

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@newives newives added the bug: pending triage Maybe a bug, waiting for confirmation label Jul 9, 2022
@brc-dd
Copy link
Member

brc-dd commented Jul 9, 2022 •
edited

Its based on scroll position right now. If that "IntelliJ IDEA" heading goes near the top, only then it will be highlighted on the outline.

@brc-dd brc-dd added enhancement New feature or request and removed bug: pending triage Maybe a bug, waiting for confirmation labels Jul 9, 2022
fi3ework added a commit to fi3ework/vitepress that referenced this issue Jul 12, 2022
@fi3ework
fix: can’t detect that the page has scrolled to the bottom (fix vuejs…
7bf954d 
…#956)
@fi3ework fi3ework mentioned this issue Jul 12, 2022
Merged
brc-dd pushed a commit that referenced this issue Jul 12, 2022
@fi3ework
fix: can't detect that the page has scrolled to the bottom (#956) (#970)
98e45af
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: can’t detect that the page has scrolled to the bottom (fix #956) fi3ework/vitepress
2 participants
@brc-dd @newives