From bc2dc96e6e62062ec5fc022dbc41310d5248913c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thorsten=20L=C3=BCnborg?= Date: Fri, 3 Jan 2020 07:51:47 +0100 Subject: [PATCH] fix(e2e-nightwatch): check for correct flag name (#5016) * fix(e2e-nightwatch): check for correct flag name flag is documented as `--use-selenium` but we checked for `args['with-selenium']` fix #5015 * test(e2e-nightwatch): selenium test uses correct flag now --- .../__tests__/nightwatchPlugin.spec.js | 2 +- packages/@vue/cli-plugin-e2e-nightwatch/index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js b/packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js index bdd7c056b9..3a3e8b101e 100644 --- a/packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js +++ b/packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js @@ -69,7 +69,7 @@ describe('nightwatch e2e plugin', () => { }) test('should run single test with custom nightwatch.json and selenium server', async () => { - await project.run(`vue-cli-service test:e2e --headless --with-selenium -t tests/e2e/specs/test.js`) + await project.run(`vue-cli-service test:e2e --headless --use-selenium -t tests/e2e/specs/test.js`) let results = await project.read('test_results.json') results = JSON.parse(results) diff --git a/packages/@vue/cli-plugin-e2e-nightwatch/index.js b/packages/@vue/cli-plugin-e2e-nightwatch/index.js index 3f1c42e120..cb1a595a79 100644 --- a/packages/@vue/cli-plugin-e2e-nightwatch/index.js +++ b/packages/@vue/cli-plugin-e2e-nightwatch/index.js @@ -65,7 +65,7 @@ module.exports = (api, options) => { rawArgs.push('--env', 'chrome') } - if (args['with-selenium']) { + if (args['use-selenium']) { process.env.VUE_NIGHTWATCH_USE_SELENIUM = '1' }