Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnoreToast is added to the start menu when notifying on Windows #2720

Closed
evelynhathaway opened this issue Oct 12, 2018 · 40 comments · Fixed by #6000
Closed

SnoreToast is added to the start menu when notifying on Windows #2720

evelynhathaway opened this issue Oct 12, 2018 · 40 comments · Fixed by #6000

Comments

@evelynhathaway
Copy link

Version

3.0.4

Node and OS info

Node v9.4.0, npm v5.6.0, Windows 10

Steps to reproduce

  • Install @vue/cli on Windows
  • Run vue ui on a project
  • Install/update/etc a dependency in the UI
    • Note that no notification was triggered and that %APPDATA%\Microsoft\Windows\Start Menu\Programs now has a SnoreToast shortcut
  • Install/update/etc another dependency
    • Note that a notification was triggered successfully

What is expected?

SnoreToast would not have a shortcut since the user may not like its addition to their start menu without indication of its purpose.

Additionally, the notification should trigger the first time, but I'm guessing this is caused by SnoreToast failing to notify without an app ID in the start menu to use for the notification.

What is actually happening?

The shortcut is installed without an opt-in, notification fails the first time


The UI's notification API uses node-notifier which in turn uses SnoreToast for native Windows notifications.

SnoreToast seems to indicate that a program in the start menu is necessary for notifications, though I can't find anything to back up that it needs to be in the start menu in case SnoreToast can be used from the node_modules folder.

If the CLI was an Electron app, the intended use of node-notifier would be to use the shortcut for the CLI instead (which would fix also fix the issue with it not firing and it saying the wrong app name when notifying). Since there isn't a shortcut for the CLI, it sounds like a workaround would need to be found to keep the implementation the same.

The issue with it not firing the first time is most likely related to and could be fixed by "installing" the shortcut before the first notification.

@ananaszjoe
Copy link

I had no idea what it was when I found it in my start menu, so when I ran it and it ran some scripts in a console window that appeared just for a fraction of a second, I suddenly wasn't sure it's not malware...

IMO it shouldn't add a new shortcut, or if it does, and the user starts it directly, it should display a notification that reads something like "This app is used by other apps to display notifications"

@june07
Copy link

june07 commented Dec 20, 2018

Yeah, def not cool. Ran across this just now.

@Riccarr

This comment has been minimized.

@ananaszjoe

This comment has been minimized.

@Riccarr

This comment has been minimized.

@dtbenson43
Copy link

Without a valid shortcut installed in the Start screen or in All Programs, you cannot raise a toast notification from a desktop app.

https://msdn.microsoft.com/en-us/library/windows/desktop/hh802762

@narration-sd
Copy link

What a mess. But why did this just suddenly show up to me today??? It's June 2019...

@jcsston
Copy link

jcsston commented Sep 10, 2019

Another vote to remove this.
npm install should not modify my Start Menu -> Programs folder without prompting.

A command-line program should notify the user via the command-line.

@h454n5
Copy link

h454n5 commented Sep 17, 2019

Agree with jcsston

@mariuszwojtkowski
Copy link

I agree, this is outrageous and the shortcut should not be created!

@Riccarr
There are nice and well educated people talking to each other and there is you, too. You obviously shouldn't be talking...

@shelbykauth
Copy link

I am semi-okay with the shortcut. After this issue specifically
IF AND ONLY IF the user clicks "okay, install".
Like it should open up a standard Windows "Do you want to let this program install stuff on your computer" thing like a normal program.
I nearly had a panic attack. Especially when I couldn't find it in "Uninstall or change a program" list.

Or call it something other than SnoreToast. Like NodeNotifier, so I know where the heck it came from.

@Riccarr, while I completely disagree with your tone, you do have a point.

Why would you click to run some random program?

But to that point, why would you run some random software that is maintained by a community you're not a part of, that can install random shit on your start menu? AKA: Why would you run any open-source software, including vue, ever?

Because we're programmers! That's why! The breadth of our curiosity has no bounds.

Also, I thought I had maybe installed the program along with three others yesterday and hadn't uninstalled it. So I was trying to see what it was. I couldn't remember what I had or had not installed. When the application closed, I was suddenly afraid that it was running large scripts in the background. And if running the executable by itself popped up a notification about what SnoreToast was, then I would have known what the program was and probably wouldn't have been bothered by it at all.

@angelicochris
Copy link

Is this ever going to be addressed. Only noticed it because the project creation got stuck on it. Kind of weird to add something like this without telling the user explicitly.

@instancezero
Copy link

If anyone ever decides to get around to implementing this, I'd like to add a feature request for the install process to ask where the user would like that shortcut to be created, because it is rather tedious to clean up and reorganize a start menu after every self-important application decides it belongs in the root of the start menu, and then recreates the same shortcut on every single update. I'd much rather have it down in my dev tools sub-menu...

@geoffh-aurizon
Copy link

geoffh-aurizon commented Apr 23, 2020

+1 fix this please.

I still get this on my start menu in Win10.

And the branded SnoreToast notifications that just start coming up on Windows 10 look pretty much like your box has been pwned.

@curious-monggo
Copy link

1587989339145690581628
Snoretoasts says hi. After doing some laravel.( I might have installed it thru composer or npm)

@jaruzafa
Copy link

+1 to this! Two years and not fixed yet....

@lehno
Copy link

lehno commented May 11, 2020

I thought today I had a virus or something because of this man

@Shavindra
Copy link

not really happy with random stuff getting installed without informing/consent!!! I am installing vue and cli. It shouldn't have anything to do with random notifications popping up. If anything why not just output the error in command line like others?

@rahulramsaha
Copy link

Got quite spooked today too when i opened it and a terminal popped up.
And yeah +1 to at least be notified before installing

@sodatea
Copy link
Member

sodatea commented Jun 7, 2020

It's labeled as "contribution welcome".

@JoelRummel
Copy link

+1, I too found this in my start menu and immediately thought it was malware.

@jamesperks-om
Copy link

+1, I too found this in my start menu and immediately thought it was malware.

Same!

@ccartee
Copy link

ccartee commented Jun 29, 2020

just saw this pop up

found exe, deleted, deleted shortcut.

don't install garbage without my explicit permission to do so.

@ellis2323
Copy link

Seriously, not sure it's legal in Europe!

@CoolOppo
Copy link

How is this still not fixed...?

@PawFV
Copy link

PawFV commented Aug 13, 2020

Its easier to uninstall McAffee than this thing... jesus christ.

@madsouris
Copy link

this is not cool, please fix this thing

@fatihbabacan92
Copy link

I got shocked that I might have malware on my pc. It is very unprofessional to add such a shortcut to start without notifying the user and very bad for Vue's reputation.

@Legion2
Copy link

Legion2 commented Oct 4, 2020

Why does nobody open a PR to remove it?

@FluentCoding
Copy link

Yeah, rly not cool of them ;/ And I thought that it is a malware.

@sXe79
Copy link

sXe79 commented Oct 21, 2020

Just installed itself in my Windows menu. NOT cool at all.

@mohsin
Copy link

mohsin commented Oct 23, 2020

@Legion2 Read the comments, that's why. Windows 8+ requires the start menu to be populated to have notifications appear. I think the best solution right now would be to make a postuninstall script to remove this start menu entry. Although ideally that code will have to reside in SnoreToast repo. Alternatively, node-notifier could change it's API to allow passing additional config to specify an app ID so it installs using a different app name based on the package using it. And the uninstall code can reside in this repo itself calling that specific app name to be removed from startup entry.

tony19 added a commit to tony19-contrib/vue-cli that referenced this issue Oct 24, 2020
This prevents SnoreToast from installing a Start Menu shortcut
by specifying an appID. The appID is also used to set the
notification's title bar text in Windows 10. That text is now
set to "Vue UI", which replaces the default value of "SnoreToast".

fixes vuejs#2720
@tony19
Copy link
Contributor

tony19 commented Oct 24, 2020

The solution is to provide an appID in the notify() call, which skips the Start Menu shortcut installation (resolved in PR #6000).


Once this fix lands, users may want to manually undo the SnoreToast changes from their system, as described below.

Remove SnoreToast shortcut from Start Menu

Option A: File Explorer

  1. Right-click Start Menu > SnoreToast, and choose More > Open File Location, which opens File Explorer.
  2. In File Explorer, delete the root folder of SnoreToast.

Option B: Windows Command Line

  1. Open cmd.exe

  2. Run this rmdir command:

     rmdir /s /q "%APPDATA%\Microsoft\Windows\Start Menu\Programs\SnoreToast"
    

Remove SnoreToast's registry key

Note: SnoreToast sets a registry key in order to register its notification center. The UUID seen in the key is for SnoreToast v0.7.0.

Option A: Registry Editor

  1. Open regedit.exe
  2. In the location textbox at the top, below the menu bar, enter: HKCU\Software\Classes\CLSID\{eb1fdd5b-8f70-4b5a-b230-998a2dc19303} to jump to the key in the registry.
  3. Right-click the {eb1fdd5b-8f70-4b5a-b230-998a2dc19303} folder, and choose Delete.

Option B: Windows Command Line

  1. Open cmd.exe

  2. Run this reg command:

     reg delete /f HKCU\Software\Classes\CLSID\{eb1fdd5b-8f70-4b5a-b230-998a2dc19303}
    

@mayanxoni
Copy link

It's been more than 2 years now but still no official solution to this problem. I just closed 3 tabs before coming to this issue.

@mellester
Copy link

It's been more than 2 years now but still no official solution to this problem. I just closed 3 tabs before coming to this issue.

Wel the PR fixcing it is only 17 days old so there is a solution just not ofcal yet

sodatea pushed a commit that referenced this issue Nov 14, 2020
This prevents SnoreToast from installing a Start Menu shortcut
by specifying an appID. The appID is also used to set the
notification's title bar text in Windows 10. That text is now
set to "Vue UI", which replaces the default value of "SnoreToast".

fixes #2720
sodatea pushed a commit that referenced this issue Jan 6, 2021
This prevents SnoreToast from installing a Start Menu shortcut
by specifying an appID. The appID is also used to set the
notification's title bar text in Windows 10. That text is now
set to "Vue UI", which replaces the default value of "SnoreToast".

fixes #2720
@just-tugsuu
Copy link

just-tugsuu commented Feb 10, 2021

Damn I thought it was malware or something like that :(((

@sss-ryun
Copy link

I thought I downloaded some bloatware or something from installing apps

@TheCrescentKing
Copy link

Same here, thought it was malware or a virus when I found it, I was immediately suspicious of it.

@ScarVite
Copy link

Same here, thought it was malware or a virus when I found it, I was immediately suspicious of it.

same

@jason-guru
Copy link

same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.