Don't reread the input file on ts linting #2787
Merged
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The previous build failure seemed to be related to AppVeyor. Pushing the changes again resolved the issue. |
haoqunjiang
requested changes
Nov 1, 2018
|
Hi. Thanks for the review. I added a test case which will fail on the current master branch and will pass with this fix. Since I did not change anything on the eslint part I believe that
is an unrelated error |
|
Hi @sodatea Is there anything else needed to complete this PR? |
haoqunjiang
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2786.