fix(cli-plugin-babel): transpileDependencies should only match packages inside node_modules, close #3057
#3229
+33
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkzing
changed the title
node_modules whose name match transpileDependencies, close #3057node_modules, close #3057
jkzing
commented
Jan 2, 2019
| @@ -70,10 +70,23 @@ test('dep from node_modules should not been transpiled', async () => { | |||
| test('dep from node_modules should been transpiled', async () => { | |||
| await project.write( | |||
| 'vue.config.js', | |||
| `module.exports = { transpileDependencies: ['external-dep'] }` | |||
| `module.exports = { transpileDependencies: ['external-dep', '@scope/external-dep'] }` | |||
There was a problem hiding this comment.
Why do we want to implicit include scoped package with the same name? This behavior isn't documented...
There was a problem hiding this comment.
I think it was unintended… Thanks for pointing out.
jkzing
force-pushed
the
fix-trans-dep
branch
2 times, most recently
from
be6698b to
a3177d3
Compare
haoqunjiang
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3057