Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock toolchain dependencies' version #3340

Closed
634750802 opened this issue Jan 21, 2019 · 6 comments
Closed

Lock toolchain dependencies' version #3340

634750802 opened this issue Jan 21, 2019 · 6 comments

Comments

@634750802
Copy link

What problem does this feature solve?

CI always reinstall packages, and it's difficult to find the problem from toolchains like webpack or babel. Locking the dependencies' version helps.

See issue webpack/webpack#8656.

What does the proposed API look like?

None

@LinusBorg
Copy link
Member

That problem wouldn't really have been avoided by us locking dependencies.

Plus, this means that we would have to update our own packages daily, practically speaking. Because otherwise we would risk missing patch releases.

Your project has a lock file which locks your dependencies anyway, so i don't see any worthwhile advantage in your proposal

@634750802
Copy link
Author

Thanks for reply. The fact is, I didn't know when webpack updates from v4.28.* to v4.29.0, I have to track all @vue/cli-service dependencies to find if I was wrong (My bad for not checking github issues first :)).

The cli-service is really a complicated program, how about locking the minor version to reduce the risk from other dependencies?

@Akryum
Copy link
Member

Akryum commented Jan 21, 2019

You should either have a package-lock.json or a yarn.lock file in your project if you use npm or yarn. This files already contains all the versions of all the installed packages in node_modules no matter if they are direct or transitive (dependencies of other packages). Your CI will either run npm install or yarn, which will install the exact same versions.

@Akryum Akryum closed this as completed Jan 21, 2019
@634750802
Copy link
Author

What if I upgrade some packages like @vue/cli-service? It always requires the latest version of webpack 4.

@Akryum
Copy link
Member

Akryum commented Jan 21, 2019

Unless you delete your lock file or we manually change the version in @vue/cli-service package.json, the webpack version won't change.

@634750802
Copy link
Author

It’s Wired, I haven’t deleted my lock file, but the webpack version just changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants