fix: properly load non-js config files in genCacheConfig #3632
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a2bc927#diff-04612bf191a2c1a06ac248910d9e9415R162 attempted to fix a problem with cache invalidation when javascript config files (like babel.config.js) change their content i.e. depending on an env variable.
The fix was:
However we missed to add an
else
branch to keep including non-js config files (like.browserslistrc
) in the generation of the cache key.This PR adds that
else {
branchclose #3631