fix: should not add polyfills from transform-runtime plugin #3730
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is due to a misunderstanding when upgrading babel from 7.0.0-beta.47 to 7.x. In Vue CLI, usage-based polyfills are **only** added by @babel/preset-env so that it avoids overheads. `transform-runtime` plugin adds polyfills regardless of env targets so we must disable its polyfill feature. Though, there're edge cases where runtime-helpers' polyfill dependency are not correctly added (babel/babel#7597), so we also need to whitelist `@babel/runtime` for webpack to transpile.
haoqunjiang
added a commit
to haoqunjiang/vue-cli
that referenced
this pull request
Apr 1, 2019
…uejs#3730)" This reverts commit b987969.
haoqunjiang
added a commit
that referenced
this pull request
Apr 1, 2019
haoqunjiang
added a commit
to haoqunjiang/vue-cli
that referenced
this pull request
Apr 27, 2019
…e plugin (vuejs#3730)"" This reverts commit 8c7e52d.
haoqunjiang
added a commit
that referenced
this pull request
Apr 28, 2019
The basic idea is the same as #3730, except that this time we use babel-plugin-module-resolve for aliasing instead of relying on webpack.
|
i use vuecli 3.9.2 but the project add polyfills from transform-runtime plugin。what can i do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is due to a misunderstanding when upgrading babel from 7.0.0-beta.47
to 7.x.
In Vue CLI, usage-based polyfills are only added by @babel/preset-env
so that it avoids overheads.
transform-runtimeplugin adds polyfillsregardless of env targets so we must disable its polyfill feature.
Though, there're edge cases where runtime-helpers' polyfill dependency
are not correctly added (babel/babel#7597),
so we also need to whitelist
@babel/runtimefor webpack to transpile.