Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from request package #5220

Closed
DRoet opened this issue Feb 26, 2020 · 5 comments
Closed

Migrate away from request package #5220

DRoet opened this issue Feb 26, 2020 · 5 comments

Comments

@DRoet
Copy link
Contributor

DRoet commented Feb 26, 2020

Version

4.2.2

Steps to reproduce

warning @vue/cli-plugin-babel > @vue/cli-shared-utils > request@2.88.2: request has been deprecated, see request/request#3142

What is expected?

No deprecation notices in the cli

What is actually happening?

request is being used in @vue/cli-shared-utils but is now deprecated

@sodatea
Copy link
Member

sodatea commented Feb 26, 2020

Aha! I was also thinking about this just now.
Would you like to work on a PR for it?

There may be some drop-in replacements for this package. And we can replace request-promise-native with util.promisify.

@corbinu
Copy link

corbinu commented Feb 26, 2020

I would recommend we switch to got as it is under very active development. It does have a nice comparison of alternatives if somebody else wants to propose a different option: https://github.com/sindresorhus/got#faq

@sodatea
Copy link
Member

sodatea commented Feb 27, 2020

We can switch to it in the next major version. But for now, we need a drop-in replacement. Because there are many CLI plugins depending on @vue/cli-shared-utils and I'm not sure how many of them use the request functionality in a non-trivial way.

@corbinu
Copy link

corbinu commented Feb 27, 2020

@sodatea No worries I didn't know there was a need to do it before the next major. I don't know of any drop in options however.

@ghost
Copy link

ghost commented Feb 28, 2020

request/request#3143

@jeneser
Copy link
Contributor

jeneser commented Jun 11, 2020

We can switch to it in the next major version. But for now, we need a drop-in replacement.

@sodatea Yes! got is a great choice. however, if we replace it directly, not sure what side effects. PR #5572 just replace request-promise-native with util.promisify.

I noticed a plan in project v5, i'm happy to work for it. any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants