feat: respect existing package.json #4827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyy7259
force-pushed
the
respect-existing-package.json
branch
from
9fe2f01
to
6fb189a
Compare
zyy7259
force-pushed
the
respect-existing-package.json
branch
2 times, most recently
from
9969dcc
to
401c9f0
Compare
zyy7259
force-pushed
the
respect-existing-package.json
branch
2 times, most recently
from
6b6f6c3
to
57e753e
Compare
pksunkara
reviewed
Dec 12, 2019
9 tasks
zyy7259
force-pushed
the
respect-existing-package.json
branch
5 times, most recently
from
14ea723
to
d8e51c5
Compare
|
@pksunkara hi, I have modified the code as you requested. Should I rebase the code every time when |
|
Yes, please rebase since we need to re trigger CI |
zyy7259
force-pushed
the
respect-existing-package.json
branch
from
d8e51c5
to
3971dd5
Compare
sodatea
approved these changes
Jan 3, 2020
zyy7259
force-pushed
the
respect-existing-package.json
branch
2 times, most recently
from
93c6c02
to
c47afb0
Compare
zyy7259
force-pushed
the
respect-existing-package.json
branch
from
c47afb0
to
ddf478f
Compare
mactanxin
pushed a commit
to mactanxin/vue-cli
that referenced
this pull request
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
This pull request will close #4544