feat: specify babel runtime version #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodatea
approved these changes
Dec 19, 2019
zyy7259
force-pushed
the
specify-babel-runtime-version
branch
from
b77853b
to
5615e1b
Compare
zyy7259
force-pushed
the
specify-babel-runtime-version
branch
from
5615e1b
to
14391e7
Compare
|
@sodatea Is there anything blocking from merging this? I see that you approved but haven't merged. |
pksunkara
approved these changes
Jan 6, 2020
zyy7259
force-pushed
the
specify-babel-runtime-version
branch
from
14391e7
to
dad226b
Compare
|
I was thinking about the development workflow at that time… Never mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
@babel/plugin-transform-runtimehas an option named version.By default
@babel/plugin-transform-runtimeassumes that@babel/runtime@7.0.0-beta.0is installed, which means helpers introduced later than7.0.0-beta.0will be inlined instead of imported. Which in turn leads to a larger bundle size.See babel/babel#10261 and facebook/docusaurus#2111