refactor: use the title option in the html template, instead of hard-code the project name
#5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-code the project name closes vuejs#5056
pksunkara
reviewed
Jan 13, 2020
| </head> | ||
| <body> | ||
| <noscript> | ||
| <strong>We're sorry but <%= rootOptions.projectName %> doesn't work properly without JavaScript enabled. Please enable it to continue.</strong> | ||
| <strong>We're sorry but <%%= htmlWebpackPlugin.options.title %%> doesn't work properly without JavaScript enabled. Please enable it to continue.</strong> |
There was a problem hiding this comment.
Why can't we use projectName from vue.config.js?
There was a problem hiding this comment.
rootOptions.projectName is inferred from package.json so it's equivalent to the default title option value set below.
This PR is to make the title element in the template dynamic, so that users can change the page title by configuring html-webpack-plugin. Most common use cases may be in multi-page apps.
I originally thought the title option would be injected into the page by default, like meta tags. But it turns out that users need to place an interpolation expression in the template manually. jantimon/html-webpack-plugin#1302 (comment)
mactanxin
pushed a commit
to mactanxin/vue-cli
that referenced
this pull request
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5056
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: