Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single websocket connection for HMR #5069

Merged
merged 3 commits into from Jan 13, 2020
Merged

Conversation

lbogdan
Copy link
Contributor

@lbogdan lbogdan commented Jan 10, 2020

Fixes #4947 , see that for details.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

@lbogdan
Copy link
Contributor Author

lbogdan commented Jan 10, 2020

This should be ready for review.

Things I'm not 100% sure:

  • how to expose puppeteer's network request URLs to the tests;
  • looking at 'sockjs-node' http requests, which is a webpack-dev-server implementation detail. I've tried looking for websocket connections (the http request I look for only returns the websocket options), unfortunately websocket requests don't trigger page.on('request').

@lbogdan lbogdan marked this pull request as ready for review January 10, 2020 13:54
@sodatea sodatea merged commit 7b17d61 into vuejs:dev Jan 13, 2020
mactanxin pushed a commit to mactanxin/vue-cli that referenced this pull request Feb 11, 2020
* fix(hmr-websocket): add failing test

* fix(hmr-websocket): set injectClient to false, as we inject our own client

* fix(hmr-websocket): change test project name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack-dev-server/client is loaded twice
2 participants