fix: correctly calculate cacheIdentifier from lockfiles #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follow up of vuejs#3865 fixes vuejs#4438
This reverts commit dbce88b.
The previous implementation is based on the assumption that config files have precendences, e.g. `.eslintrc.js` will take higher precendence over `.eslintrc`, and only one will take effect. This is not accurate however. For example, babel relies on both babel config and browserslist config, so we need to deal with 2 config files.
pksunkara
approved these changes
Jan 30, 2020
mactanxin
pushed a commit
to mactanxin/vue-cli
that referenced
this pull request
Feb 11, 2020
* fix: correctly calculate cacheIdentifier from lockfiles follow up of vuejs#3865 fixes vuejs#4438 * Revert "fix: correctly calculate cacheIdentifier from lockfiles" This reverts commit dbce88b. * fix: should take all configFiles and lockfiles into account The previous implementation is based on the assumption that config files have precendences, e.g. `.eslintrc.js` will take higher precendence over `.eslintrc`, and only one will take effect. This is not accurate however. For example, babel relies on both babel config and browserslist config, so we need to deal with 2 config files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up of #3865
fixes #4438
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: