Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not throw when Rule.layer is used #2000

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

nolimitdev
Copy link
Contributor

#1849
fix thanks to @nskazki

@sodatea sodatea changed the title Fix issue #1849 (Can't use Webpack's layers when VueLoader is used) fix: do not throw when Rule.layer Apr 19, 2023
@sodatea sodatea merged commit ef589df into vuejs:main Apr 19, 2023
@sodatea sodatea changed the title fix: do not throw when Rule.layer fix: do not throw when Rule.layer exists Apr 19, 2023
@sodatea sodatea changed the title fix: do not throw when Rule.layer exists fix: do not throw when Rule.layer is used Apr 19, 2023
freddy38510 pushed a commit to freddy38510/vue-loader that referenced this pull request May 26, 2023
Related to vuejs#1849 but this PR doesn't fix the problem that `component.vue?type=style` doesn't inherit the layer.
It only ensures that webpack does not throw, and all existing usages aren't broken by `vue-loader`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants