Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): ensure mergeProps skips undefined event handlers (fix #5296) #5299

Merged
merged 2 commits into from Jan 21, 2022

Conversation

LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Jan 20, 2022

closes #5296

Note: The true fix is in mergeProps' handling of on* props whose values are undefined, but I also added a nonnull check in patchStopImmediatePropagation for good measure.

@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 93557af

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/61ea4e8e37971300096d3b1d

😎 Browse the preview: https://deploy-preview-5299--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 93557af

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/61ea4e8ee9e9050008a63600

😎 Browse the preview: https://deploy-preview-5299--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 93557af

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/61ea4e8ee53e88000824dae2

😎 Browse the preview: https://deploy-preview-5299--vuejs-coverage.netlify.app

@yyx990803 yyx990803 merged commit c35ec47 into main Jan 21, 2022
@yyx990803 yyx990803 deleted the linusborg/fix-mergeprops-5296 branch January 21, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mergeProps does not merge correctly event listeners
2 participants