Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling next(false); unexpectedly clears forward history #2821

Closed
pretzelhammer opened this issue Jun 24, 2019 · 1 comment
Closed

calling next(false); unexpectedly clears forward history #2821

pretzelhammer opened this issue Jun 24, 2019 · 1 comment

Comments

@pretzelhammer
Copy link

Version

3.0.1

Reproduction link

https://codesandbox.io/s/7l33b

Steps to reproduce

  • Click through the router-links on the page to get some history (a prompt will pop up on every navigation, click "OK")
  • Go back a few times (using either the browser back button or the HTML "go back" button)
  • After you are somewhere in the middle of your history/navigation stack, go forward or back (again using either the browser or HTML buttons) but this time when the prompt pops up asking you if you want to proceed, click "Cancel"
  • All of your forward history is gone

What is expected?

I don't expect all of the forward history to disappear just because a component cancelled navigation, i.e. next(false);

What is actually happening?

All of the forward history is disappearing after a component cancels navigation, i.e. next(false);

@posva
Copy link
Member

posva commented Jun 24, 2019

Duplicate of #2814

@posva posva marked this as a duplicate of #2814 Jun 24, 2019
@posva posva closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants