New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle errors in destroy #1106

Merged

eddyerburgh merged 4 commits into vuejs:dev from eddyerburgh:handle-errors-in-destroy

Jan 20, 2019

Member

eddyerburgh commented Jan 20, 2019

Throw if error thrown when instance destroyed

Fixes #1105

eddyerburgh added 4 commits

January 20, 2019 08:06


          fix: throw error after destroy

e0115fd


          fix: handle extended components

ecd23af


          refactor: combine conditions

4523b85


          refactor: improve comment

a2ff835

eddyerburgh merged commit efab983 into vuejs:dev

eddyerburgh deleted the handle-errors-in-destroy branch

January 20, 2019 11:18

Contributor

Haroenv commented Jan 20, 2019

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment