Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server-test-utils: render() returns Cheerio not string #1143

Merged
merged 1 commit into from Feb 12, 2019
Merged

server-test-utils: render() returns Cheerio not string #1143

merged 1 commit into from Feb 12, 2019

Conversation

wiese
Copy link
Contributor

@wiese wiese commented Feb 10, 2019

The documentation (https://vue-test-utils.vuejs.org/api/render.html#render)
as well as the implementation state render()'s return type as Cheerio,
the type definition should consequently do the same.

Please take a good look at the dist files - there is quite a bit of iffy change, possibly due to different versions of tools being used. I could not find infrastructure instructions (e.g. Dockerfile) however. Please advise / rebuild.

Introduced during #618
Fixes #1131

@eddyerburgh
Copy link
Member

Thanks, can you reset the dist files to master (we only update them when we release a new version)

The documentation (https://vue-test-utils.vuejs.org/api/render.html#render)
as well as the implementation state render()'s return type as `Cheerio`,
the type definition should consequently do the same.

Introduced during #618
Fixes #1131
@wiese
Copy link
Contributor Author

wiese commented Feb 11, 2019

Thanks, @eddyerburgh. Did so.

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@eddyerburgh eddyerburgh merged commit 8a9757c into vuejs:dev Feb 12, 2019
@wiese wiese deleted the server-render-return-val branch February 12, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants