Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support lazy modifier with setValue #1467

Merged
merged 5 commits into from Mar 13, 2020
Merged

Conversation

lmiller1990
Copy link
Member

Fixes #1465

Copy link

@jaredmcateer jaredmcateer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than @dobromir-hristov's review points this is a satisfactory solution for me. Thanks for the quick turnaround!

@lmiller1990
Copy link
Member Author

passes locally - why is CI failing? 🤔

@lmiller1990
Copy link
Member Author

oh, I guess lazy isn't in old versions of Vue. I'll fix that.

@lmiller1990 lmiller1990 merged commit afd7a82 into dev Mar 13, 2020
@lmiller1990 lmiller1990 deleted the feature/1465-set-value-lazy branch March 13, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setValue does not apply changes to model when lazy modifier is present
3 participants