Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Cheerio' is used, but not imported in server-test-utils/types #1526

Closed
sk-pub opened this issue May 4, 2020 · 2 comments
Closed

'Cheerio' is used, but not imported in server-test-utils/types #1526

sk-pub opened this issue May 4, 2020 · 2 comments

Comments

@sk-pub
Copy link
Contributor

sk-pub commented May 4, 2020

Version

1.0.0-beta.33

Steps to reproduce

  1. Check the file https://github.com/vuejs/vue-test-utils/blob/dev/packages/server-test-utils/types/index.d.ts
  2. It contains the usage of the Cheerio type, but the type is not defined/imported

What is expected?

The Cheerio type must be imported from '@types/cheerio'.

What is actually happening?

This issue prevents TypeScript compilation.
sk-pub pushed a commit to sk-pub/vue-test-utils that referenced this issue May 4, 2020
vuejs#1526: Fixed missing import of the Cheerio type
4ba696a
@sk-pub
Copy link
Contributor Author

sk-pub commented May 4, 2020

Made a fix: #1527

sk-pub pushed a commit to sk-pub/vue-test-utils that referenced this issue May 4, 2020
fix: added missing import of the Cheerio type (fix vuejs#1526)
9ad3f10
@lmiller1990
Copy link
Member

🤔 strange that this was un-noticed for so long! I will review the PR in the next day or so and give it a test. Thanks!

sk-pub pushed a commit to sk-pub/vue-test-utils that referenced this issue May 15, 2020
fix: added missing import of the Cheerio type (fix vuejs#1526)
ffb4c88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sk-pub @lmiller1990