Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attachToDocument conditional deprecation message, fix #1545 #1546

Merged
merged 2 commits into from May 14, 2020

Conversation

phiter
Copy link
Contributor

@phiter phiter commented May 13, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
resolves #1545

@afontcu afontcu changed the title #1545: add attachToDocument conditional deprecation message Add attachToDocument conditional deprecation message, fix #1545 May 13, 2020
@afontcu
Copy link
Member

afontcu commented May 13, 2020

Looks good! Fancy to add a unit test?

@phiter
Copy link
Contributor Author

phiter commented May 13, 2020

@afontcu do you know when it's possible to release this fix? I want to use the latest version in my codebase but I'm getting lots of warnings.

@phiter
Copy link
Contributor Author

phiter commented May 13, 2020

Looks good! Fancy to add a unit test?

Sure!

@afontcu I sent you a DM on Discord because I have a question.

@lmiller1990 lmiller1990 self-requested a review May 14, 2020 14:03
@lmiller1990 lmiller1990 merged commit 35dacdc into vuejs:dev May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting showDeprecationWarnings to false does not hide attachToDocument deprecation warnings.
4 participants