feat: remove deprecation warning from isVisible method
#1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good – I guess we should update https://vue-test-utils.vuejs.org/upgrading-to-v1/#isvisible too? |
xanf
force-pushed
the
xanf-undeprecate-is-visible
branch
from
4de4f22
to
e92fde9
Compare
Great catch, fixed! |
xanf
force-pushed
the
xanf-undeprecate-is-visible
branch
from
e92fde9
to
2600f64
Compare
update `isVisible` logic to match implementation in `jest-dom`
xanf
force-pushed
the
xanf-undeprecate-is-visible
branch
from
2600f64
to
705701f
Compare
lmiller1990
approved these changes
Sep 8, 2020
|
Thank you for pushing back on these deprecations @xanf |
|
I will release 1.1 this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1532
This PR removes deprecation from
isVisiblemethod since this method is expected to be available for testingv-showdirectiveLogic of method is ported from
jest-domimplementation (obviously we can't rely ongetComputedStyleso we do not test CSS-based visibility)What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)