Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: treat document.body in attachTo in special way #1699

Merged
merged 1 commit into from Oct 1, 2020
Merged

feat: treat document.body in attachTo in special way #1699

merged 1 commit into from Oct 1, 2020

Conversation

xanf
Copy link
Contributor

@xanf xanf commented Sep 28, 2020 •
edited

When using attachTo with document.body as a target do not replace original content of body but append a new div instead

See #1578 for details and discussion

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@xanf xanf force-pushed the xanf-add-document-body-behavior branch from 0ef42ee to 7d07d68 Compare September 28, 2020 11:40
@xanf
feat: treat document.body in attachTo in special way
09a34dd 
When using attachTo with document.body as a target do not replace
original content of body but append a new div instead

See vuejs#1578 for details and discussion
@xanf xanf force-pushed the xanf-add-document-body-behavior branch from 7d07d68 to 09a34dd Compare September 28, 2020 12:24
lmiller1990
lmiller1990 approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@lmiller1990 lmiller1990 merged commit a821908 into vuejs:dev Oct 1, 2020
@lmiller1990 lmiller1990 mentioned this pull request Oct 1, 2020
Closed
@RaphaelDDL RaphaelDDL mentioned this pull request May 26, 2021
Merged
12 tasks
lmiller1990 pushed a commit that referenced this pull request Jun 13, 2021
@RaphaelDDL
fix: Updates attachToDocument documentation tip (#1852)
9c05f2e 
Closes #1725

Updates  attachToDocument documentation tip from the div boilerplate from #1584 & #1611 to the new handling from #1578 & #1699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xanf @lmiller1990