feat: warn when operating on destroyed Vue component, fix #1685 #1706
+114
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xanf
commented
Oct 2, 2020
|
|
||
| const StubComponent = { template: '<div><p></p></div>' } | ||
|
|
||
| ;[ |
There was a problem hiding this comment.
It would be great to use jest.each here, but that will fail in Karma :(
There was a problem hiding this comment.
A lot of cool jest things fail in karma... all good.
xanf
force-pushed
the
xanf-warn-on-destroyed
branch
from
45cf4df
to
707bd2a
Compare
lmiller1990
approved these changes
Oct 7, 2020
|
|
||
| const StubComponent = { template: '<div><p></p></div>' } | ||
|
|
||
| ;[ |
There was a problem hiding this comment.
A lot of cool jest things fail in karma... all good.
|
@xanf thanks I can release this weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1685 for original idea
In general, I've decided to go with warning as more relaxed way instead of throwing
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes: