Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Wrapper type definition #1741

Merged
merged 1 commit into from Nov 26, 2020
Merged

fix Wrapper type definition #1741

merged 1 commit into from Nov 26, 2020

Conversation

DevAnouar-FT
Copy link
Contributor

Added the getComponent() function typing

What kind of change does this PR introduce? (check at least one)

  • [ x] Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [x ] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • [ x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Added the getComponent() function typing
@lmiller1990
Copy link
Member

Thanks!

@lmiller1990 lmiller1990 merged commit 62dec1c into vuejs:dev Nov 26, 2020
@DevAnouar-FT DevAnouar-FT deleted the patch-1 branch November 26, 2020 23:42
@DevAnouar-FT
Copy link
Contributor Author

Thanks!

You're welcome!

@lmiller1990
Copy link
Member

I can release this weekend 👍

@DevAnouar-FT
Copy link
Contributor Author

I can release this weekend

Great news! That would be awesome to get rid of augmenting the Wrapper type, at work starting from next week, just for this. Thank you in advance for the release 👍

@lmiller1990
Copy link
Member

Awesome... if you can consider Vue 3 + Test Utils V2 - written in TS. no type problems!

@DevAnouar-FT
Copy link
Contributor Author

DevAnouar-FT commented Nov 27, 2020

Awesome... if you can consider Vue 3 + Test Utils V2 - written in TS. no type problems!

Indeed! Unfortunately, we are still using Vue 2 as we can't migrate to Vue 3 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants