Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of Array.prototype.find breaks unit tests in browsers that do not support this. #499

Closed
rikbrowning opened this issue Mar 29, 2018 · 4 comments · Fixed by #572
Closed

Use of Array.prototype.find breaks unit tests in browsers that do not support this. #499

rikbrowning opened this issue Mar 29, 2018 · 4 comments · Fixed by #572
Labels
intend to implement

Comments

@rikbrowning
Copy link

Version

1.0.0-beta.13

Reproduction link

Run Test in IE10

Steps to reproduce

  1. Create unit test using test-utils, use mount command.
  2. Run test in IE10
  3. Test will fail due to TypeError: Object doesn't support property or method 'find'

What is expected?

Test should pass

What is actually happening?

Test is failing.
@malte-christian
Copy link

This bug was introduced with #462.

@38elements
Copy link
Contributor

I think if this is a issue to resolve and this issue is resolved by reverting #462,
#462 should be reverted.

@eddyerburgh
Copy link
Member

Yes, I also think we should run tests in Phantom to stop this in the future. Currently we run in headless chrome, but we Phantom has less support for features.

@38elements
Copy link
Contributor

I think this is resolved by using core-js.

eddyerburgh added a commit to eddyerburgh/vue-test-utils that referenced this issue Apr 30, 2018
@eddyerburgh
fix: run tests in phantom
cca3e8f 
fixes vuejs#499
@eddyerburgh eddyerburgh mentioned this issue Apr 30, 2018
Merged
eddyerburgh added a commit that referenced this issue May 4, 2018
@eddyerburgh
fix: remove Array.find (#572)
01686a0 
run tests in phantom

fixes #499
@honeroku honeroku mentioned this issue May 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
intend to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove Array.find eddyerburgh/vue-test-utils
4 participants
@rikbrowning @38elements @malte-christian @eddyerburgh