feat: Adds provide to the global config.
#555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyerburgh
reviewed
Apr 25, 2018
| @@ -44,4 +56,38 @@ describeWithMountingMethods('options.provide', (mountingMethod) => { | |||
|
|
|||
| expect(wrapper.vm.setInBeforeCreate).to.equal('created') | |||
| }) | |||
|
|
|||
| it('injects the provide from the config', () => { | |||
There was a problem hiding this comment.
You can use the itDoNotRunIf and injectSupported functions to only run for Vue versions which support inject/provide. Example—https://github.com/vuejs/vue-test-utils/blob/dev/test/specs/mounting-options/provide.spec.js#L9
There was a problem hiding this comment.
@eddyerburgh Done in 0ee6ce8. Did amend the existing commit.
eddyerburgh
requested changes
Apr 25, 2018
jeremyzahner
force-pushed
the
feature/feat-provide-inject
branch
from
c293cf1
to
0ee6ce8
Compare
|
@eddyerburgh Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on our current project, we noticed that mocking global provides (usually provided by the root Vue instance) is quite painful because it needs to be added to every single mount()/shallow() in the tests.
This implements the config abilities that the mocks, stubs and methods also have.
The only feature that we can not easily support is the merging of functions (obviously). We did implement an error to signal this very clearly.