Refactor: refactor add-slots.js #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusarz
commented
Apr 24, 2018
| elem = vm.$createElement(compileToFunctions(slotValue)) | ||
| } else { | ||
| const compiledResult = compileToFunctions(`<div>${slotValue}{{ }}</div>`) | ||
| const _staticRenderFns = vm._renderProxy.$options.staticRenderFns |
There was a problem hiding this comment.
I removed this 'replacing' of staticRenderFns and didn't experienced unit-test failures - is it ok to remove, or I miss something ?
There was a problem hiding this comment.
I don't think it's OK to remove, but we should add some tests to cover it. Can you write a test to check that a static slot is added correctly.
There was a problem hiding this comment.
Thanks @eddyerburgh for information - I'll add appropriate tests for that
There was a problem hiding this comment.
I moved back staticRenderFns related code in pull request. To be honest I don't know what is static slot - I'm not yet familiar with everything related with Vue.
lusarz
commented
Apr 24, 2018
| return Array.isArray(value) ? value : [value] | ||
| } | ||
|
|
||
| export function isObject (obj: mixed): boolean %checks { |
There was a problem hiding this comment.
This method is copied from Vue
eddyerburgh
approved these changes
Apr 26, 2018
Merged
eddyerburgh
pushed a commit
that referenced
this pull request
May 5, 2018
* Revert "refactor: refactor stub-components.js (#544)" This reverts commit db5e07e. * Revert "refactor: refactor add-slots.js (#556)" This reverts commit ce9e1bf. * delete packages/test-utils/src/shallow.js * add functions * add type SlotValue * add test * fix slotValue * fix validateEnvironment * add test * fix lint * Update slots.spec.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.