Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): shallow -> shallowMount #587

Merged
merged 1 commit into from May 6, 2018
Merged

fix(types): shallow -> shallowMount #587

merged 1 commit into from May 6, 2018

Conversation

38elements
Copy link
Contributor

@38elements 38elements commented May 6, 2018 •
edited

This changes shallow to shallowMount in types.

eddyerburgh
eddyerburgh approved these changes May 6, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm planning on moving the whole repository to use typescript instead of flow, that way we could use the types in the unit tests and stop them going out of sync with the source code.

@eddyerburgh eddyerburgh merged commit c3e013e into vuejs:dev May 6, 2018
@38elements
Copy link
Contributor Author

I think it is good.

@38elements 38elements deleted the types branch May 7, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@38elements @eddyerburgh